Bug 15569

Summary:

[gtk] GTK JavaScriptCore needs to export symbols for JSC API and WTF

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alp, aroben, ggaren, jmalonzo, mrowe

Priority:

Keywords:

Gtk

Version:

523.x (Safari 3)

Hardware:

OS:

OS X 10.4

Bug Depends on:

Bug Blocks:

15561, 15687

Attachments:

Description	Flags
Export API symbols in the headers	none
Update Win check and don't bother with Metrowerks	none
Now with non-GCC support	mjs: review+

Eric Seidel (no email)

Reported 2007-10-19 20:45:56 PDT

[gtk] GTK JavaScriptCore needs to export symbols for JSC API and WTF The Mac/Win ports use an exported symbols file for this. I would suggest GTK do the same. This blocks further progress on DRT.

Attachments
Export API symbols in the headers (31.39 KB, patch) 2007-11-25 18:25 PST, Alp Toker	no flags	Details Formatted Diff Diff
Update Win check and don't bother with Metrowerks (31.31 KB, patch) 2007-11-25 18:54 PST, Alp Toker	no flags	Details Formatted Diff Diff
Now with non-GCC support (31.27 KB, patch) 2007-11-26 23:33 PST, Alp Toker	mjs: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2007-10-20 03:25:44 PDT

One problem with using an exports file is that compilers on different platforms all have different means of specifying the exports file, and the same compiler on different platforms may mangle names in a different manner. The approach used within the Gtk API code is to have a #define that marks a symbol as having default visibility (eg, as being exported) when building, and to set the default symbol visibility to private.

Alp Toker

Comment 2 2007-11-25 17:54:22 PST

See also: http://bugs.webkit.org/show_bug.cgi?id=16029

Alp Toker

Comment 3 2007-11-25 18:25:39 PST

Created attachment 17521 [details] Export API symbols in the headers This does the job for the GTK+ port, but I'm not sure what is defined for Windows and Mac builds of JavaScriptCore, so those parts might well be wrong. Adam?

Alp Toker

Comment 4 2007-11-25 18:54:20 PST

Created attachment 17522 [details] Update Win check and don't bother with Metrowerks I think this still needs a Win-savvy reviewer to take a look first.

Adam Roben (:aroben)

Comment 5 2007-11-25 20:51:24 PST

Comment on attachment 17522 [details] Update Win check and don't bother with Metrowerks This looks OK on the Windows side.

Alp Toker

Comment 6 2007-11-26 23:33:37 PST

Created attachment 17543 [details] Now with non-GCC support I think we've covered Win, Mac and non-GCC now. Good to go?

Maciej Stachowiak

Comment 7 2007-11-27 20:15:50 PST

Comment on attachment 17543 [details] Now with non-GCC support r=me Looks fine, let's make sure to do this at a time when you can watch the buildbots to make sure it worked out ok.

Alp Toker

Comment 8 2007-11-27 22:03:39 PST

Landed in r28097 (with MSVC support disabled in r28100 to fix the Win build).

Alp Toker

Comment 9 2007-12-01 16:10:07 PST

See http://bugs.webkit.org/show_bug.cgi?id=16227 for updates on the Win/MSVC situation.

Note You need to log in before you can comment on or make changes to this bug.