RESOLVED FIXED 16227
[WIN] JavaScriptCore should export API using JS_EXPORT 
https://bugs.webkit.org/show_bug.cgi?id=16227
Summary [WIN] JavaScriptCore should export API using JS_EXPORT
Alp Toker
Reported 2007-12-01 16:09:20 PST
The patch in http://bugs.webkit.org/show_bug.cgi?id=15569 introduced JS_EXPORT to export public API without defs file entries in r28097. It was backed out in r28100 because we couldn't figure out how to define JS_BUILDING_JS in the windows build system (which is required by MSVC to decide between dllimport and dllexport). Once this is done, r28100 should be re-introduced and redundant entries removed from the Win defs file.
Attachments
Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2009-04-20 17:21:16 PDT
This is fixed in r42680 for the Windows build. The change requires proper definition of a BUILDING_{projectname} preprocessor def. We have this defined in win/tools/vsprops/common.vsprops.
Darin Adler
Comment 2 2009-07-06 10:39:49 PDT
There’s still a comment with this bug number in it in JSBase.h. What should we do about that?
Steve Falkenburg
Comment 3 2009-07-06 10:48:55 PDT
I'll remove the comment.
Note You need to log in before you can comment on or make changes to this bug.