Bug 155673

Summary: Add unit tests for measurement-set.js and measurement-adapter.js
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, joepeck, kling, koivisto, rniwa, slewis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds tests and refactors code
darin: review+
Add tests for real dbates: review+

Ryosuke Niwa
Reported 2016-03-18 17:14:16 PDT
Add mocha unit tests for measurement-set.js and measurement-adapter.js as these two files are responsible for fetching and formatting data on v3 UI and new syncing / regression detection scripts to be (re)written.
Attachments
Adds tests and refactors code (30.69 KB, patch)
2016-03-18 18:52 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
Add tests for real (25.64 KB, patch)
2016-03-18 19:22 PDT, Ryosuke Niwa 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-03-18 18:52:52 PDT
Created attachment 274486 [details] Adds tests and refactors code
Ryosuke Niwa
Comment 2 2016-03-18 19:17:08 PDT
Thanks for the review!
Ryosuke Niwa
Comment 3 2016-03-18 19:17:50 PDT
Committed r198462: <http://trac.webkit.org/changeset/198462>
Ryosuke Niwa
Comment 4 2016-03-18 19:22:14 PDT
Oops, my patch didn't have actual tests :(
Ryosuke Niwa
Comment 5 2016-03-18 19:22:22 PDT
Created attachment 274491 [details] Add tests for real
Daniel Bates
Comment 6 2016-03-18 19:42:44 PDT
Comment on attachment 274491 [details] Add tests for real View in context: https://bugs.webkit.org/attachment.cgi?id=274491&action=review rs=me. Feel free to ask someone more familiar with measurement-set.js and measurement-adapter.js for a more through review. > Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js:1 > +'use strict'; This file alternates between using single quoted string literals and double quoted string literals. We should pick one style and stick with it for consistency. > Websites/perf.webkit.org/unit-tests/measurement-set-tests.js:1 > +'use strict'; This file alternates between using single quoted string literals and double quoted string literals. We should pick one style and stick with it for consistency.
Ryosuke Niwa
Comment 7 2016-03-18 19:49:49 PDT
Will fix. Thanks!
Ryosuke Niwa
Comment 8 2016-03-18 19:50:48 PDT
Committed r198463: <http://trac.webkit.org/changeset/198463>
Note You need to log in before you can comment on or make changes to this bug.