Bug 155661

Summary: Give NSURLSessionConfiguration information about parent process
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, buildbot, dbates, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Patch none

Alex Christensen
Reported 2016-03-18 13:47:57 PDT
Give NSURLSessionConfiguration information about parent process
Attachments
Patch (12.78 KB, patch)
2016-03-18 15:27 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (12.79 KB, patch)
2016-03-18 15:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (504.21 KB, application/zip)
2016-03-18 16:26 PDT, Build Bot 		no flags
Details
Patch (12.52 KB, patch)
2016-03-18 16:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-03-18 15:27:17 PDT
Created attachment 274459 [details] Patch
Alex Christensen
Comment 2 2016-03-18 15:49:40 PDT
Created attachment 274463 [details] Patch
Alex Christensen
Comment 3 2016-03-18 15:50:52 PDT
Second patch rebased to apply to trunk and made it so we get the audit token on mac just like we do on ios.
Build Bot
Comment 4 2016-03-18 16:26:46 PDT
Comment on attachment 274463 [details] Patch Attachment 274463 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1001862 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2016-03-18 16:26:49 PDT
Created attachment 274474 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Alex Christensen
Comment 6 2016-03-18 16:58:03 PDT
Created attachment 274478 [details] Patch
Alex Christensen
Comment 7 2016-03-18 16:58:53 PDT
Mac doesn't like the audit token. Landing without changing Mac behavior.
Alex Christensen
Comment 8 2016-03-18 17:05:32 PDT
http://trac.webkit.org/changeset/198457
Joseph Pecoraro
Comment 9 2016-03-18 17:13:34 PDT
Comment on attachment 274478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274478&action=review > Source/WebKit2/WebProcess/WebProcess.cpp:381 > +#if USE(NETWORK_SESSION) > + NetworkSession::setSourceApplicationAuditTokenData(sourceApplicationAuditData()); > +#endif Can the ENABLE(REMOTE_INSPECTOR) code right about this also use sourceApplicationAuditData()?
Alex Christensen
Comment 10 2016-03-18 19:19:14 PDT
It could on iOS, but on mac we need to return nullptr or it causes problems, but your code needs the actual audit token on mac. We could use the same code on iOS, though, to avoid asking the ui process twice on startup on iOS.
Alexey Proskuryakov
Comment 11 2016-03-19 12:00:10 PDT
I wonder if this "audit token data" contains process bundle ID that we could use when initializing the sandbox.
Note You need to log in before you can comment on or make changes to this bug.