Bug 155654

Summary: ES6 spec requires that RegExpPrototype not be a RegExp object.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch: rebased to ToT. fpizlo: review+

Mark Lam
Reported 2016-03-18 11:13:54 PDT
The ES6 spec states that RegExp.prototype should not be an instance of RegExp: https://tc39.github.io/ecma262/#sec-properties-of-the-regexp-prototype-object "The RegExp prototype object is an ordinary object. It is not a RegExp instance and does not have a [[RegExpMatcher]] internal slot or any of the other internal slots of RegExp instance objects."
Attachments
proposed patch. (30.78 KB, patch)
2016-03-18 11:28 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch: rebased to ToT. (30.75 KB, patch)
2016-03-18 11:31 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-18 11:14:51 PDT
<rdar://problem/25243459>
Mark Lam
Comment 2 2016-03-18 11:28:23 PDT
Created attachment 274436 [details] proposed patch.
Mark Lam
Comment 3 2016-03-18 11:31:49 PDT
Created attachment 274437 [details] proposed patch: rebased to ToT.
Mark Lam
Comment 4 2016-03-18 13:27:09 PDT
This patch has passed the JSC and layout tests. The reason the EWS bots are failing to apply the patch is because the CR characters in the ietestcenter tests are making the patcher barf. The patch is ready for a review.
Mark Lam
Comment 5 2016-03-18 16:15:21 PDT
Thanks for the review. Landed in r198447: <http://trac.webkit.org/r198447>.
Note You need to log in before you can comment on or make changes to this bug.