Bug 155622

Summary: Add a setting to let the client toggle support for network cache speculative validation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, barraclough, commit-queue, koivisto, mitz, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-03-17 20:31:02 PDT
Add a setting to let the client toggle support for network cache speculative validation.
Attachments
WIP patch (5.30 KB, patch)
2016-03-18 14:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.14 KB, patch)
2016-03-18 16:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.32 KB, patch)
2016-03-18 16:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2016-03-20 10:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-03-17 20:32:56 PDT
Planning to have the setting off by default.
Radar WebKit Bug Importer
Comment 2 2016-03-17 20:33:27 PDT
<rdar://problem/25233209>
Radar WebKit Bug Importer
Comment 3 2016-03-17 20:33:28 PDT
<rdar://problem/25233210>
Anders Carlsson
Comment 4 2016-03-18 10:17:10 PDT
Make sure this is not implemented as a WKPreference in the modern API.
Chris Dumez
Comment 5 2016-03-18 14:52:22 PDT
Created attachment 274455 [details] WIP patch
Chris Dumez
Comment 6 2016-03-18 16:04:41 PDT
Created attachment 274467 [details] Patch
Alex Christensen
Comment 7 2016-03-18 16:39:01 PDT
Comment on attachment 274467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274467&action=review > Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251 > + parameters.shouldEnableNetworkCacheSpeculativeRevalidation = m_configuration->diskCacheSpeculativeValidationEnabled() && [defaults boolForKey:WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey]; Don't we want to get rid of the WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey, too?
Anders Carlsson
Comment 8 2016-03-18 16:40:02 PDT
Comment on attachment 274467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274467&action=review >> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251 >> + parameters.shouldEnableNetworkCacheSpeculativeRevalidation = m_configuration->diskCacheSpeculativeValidationEnabled() && [defaults boolForKey:WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey]; > > Don't we want to get rid of the WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey, too? Yeah, we don't want a defaults key in WebKit.
Chris Dumez
Comment 9 2016-03-18 16:47:45 PDT
Created attachment 274477 [details] Patch
WebKit Commit Bot
Comment 10 2016-03-19 11:46:54 PDT
Comment on attachment 274477 [details] Patch Clearing flags on attachment: 274477 Committed r198470: <http://trac.webkit.org/changeset/198470>
WebKit Commit Bot
Comment 11 2016-03-19 11:47:00 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 12 2016-03-20 10:45:23 PDT
Reopening for a follow-up as I found a bug.
Chris Dumez
Comment 13 2016-03-20 10:47:28 PDT
Created attachment 274544 [details] Patch
Chris Dumez
Comment 14 2016-03-22 09:23:42 PDT
ping review?
WebKit Commit Bot
Comment 15 2016-03-22 12:21:56 PDT
Comment on attachment 274544 [details] Patch Clearing flags on attachment: 274544 Committed r198544: <http://trac.webkit.org/changeset/198544>
WebKit Commit Bot
Comment 16 2016-03-22 12:22:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.