Bug 155612

Summary: SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=155254
Attachments:
Description Flags
Patch
none
Patch aestes: review+

Alex Christensen
Reported 2016-03-17 17:18:26 PDT
SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response
Attachments
Patch (1.85 KB, patch)
2016-03-17 19:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.04 KB, patch)
2016-03-17 20:30 PDT, Alex Christensen 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-03-17 19:54:31 PDT
Created attachment 274361 [details] Patch
Chris Dumez
Comment 2 2016-03-17 19:59:35 PDT
Comment on attachment 274361 [details] Patch lgtm. Antti, can you please use your new WK2 owner powers?
Sam Weinig
Comment 3 2016-03-17 20:11:09 PDT
Comment on attachment 274361 [details] Patch What is the testing strategy for this?
Chris Dumez
Comment 4 2016-03-17 20:26:06 PDT
(In reply to comment #3) > Comment on attachment 274361 [details] > Patch > > What is the testing strategy for this? Layout testing speculative loading is currently not easy but I filed: https://bugs.webkit.org/show_bug.cgi?id=155254 and am planning to work on adding test support very soon.
Chris Dumez
Comment 5 2016-03-17 20:26:33 PDT
Comment on attachment 274361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274361&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:69 > + m_networkLoad->continueWillSendRequest(newRequest); this does not even build :D
Alex Christensen
Comment 6 2016-03-17 20:30:52 PDT
Created attachment 274363 [details] Patch
Alex Christensen
Comment 7 2016-03-17 23:13:06 PDT
http://trac.webkit.org/changeset/198378
Alex Christensen
Comment 8 2016-03-18 10:53:48 PDT
rdar://problem/24843454
Note You need to log in before you can comment on or make changes to this bug.