Bug 155610

Summary: Web Inspector: protocol generator shouldn't generate enums for parameters with non-anonymous enum types
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2016-03-17 16:56:59 PDT
These enums are completely redundant and clutter up the generated header.
Attachments
Proposed Fix (5.36 KB, patch)
2016-03-17 17:01 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-17 16:57:22 PDT
<rdar://problem/25229878>
Blaze Burg
Comment 2 2016-03-17 17:01:57 PDT
Created attachment 274342 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-03-17 17:02:48 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Joseph Pecoraro
Comment 4 2016-03-17 17:53:28 PDT
Comment on attachment 274342 [details] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2016-03-17 18:43:10 PDT
Comment on attachment 274342 [details] Proposed Fix Clearing flags on attachment: 274342 Committed r198373: <http://trac.webkit.org/changeset/198373>
WebKit Commit Bot
Comment 6 2016-03-17 18:43:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.