Bug 155610 - Web Inspector: protocol generator shouldn't generate enums for parameters with non-anonymous enum types
Summary: Web Inspector: protocol generator shouldn't generate enums for parameters wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-17 16:56 PDT by BJ Burg
Modified: 2016-03-17 18:43 PDT (History)
12 users (show)

See Also:

Attachments
Proposed Fix (5.36 KB, patch)
2016-03-17 17:01 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-03-17 16:56:59 PDT 
These enums are completely redundant and clutter up the generated header.
Comment 1 Radar WebKit Bug Importer 2016-03-17 16:57:22 PDT 
<rdar://problem/25229878>
Comment 2 BJ Burg 2016-03-17 17:01:57 PDT 
Created attachment 274342 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-03-17 17:02:48 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Joseph Pecoraro 2016-03-17 17:53:28 PDT 
Comment on attachment 274342 [details]
Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2016-03-17 18:43:10 PDT 
Comment on attachment 274342 [details]
Proposed Fix

Clearing flags on attachment: 274342

Committed r198373: <http://trac.webkit.org/changeset/198373>
Comment 6 WebKit Commit Bot 2016-03-17 18:43:16 PDT 
All reviewed patches have been landed.  Closing bug.