Bug 155599

Summary: Media elements allowed to play without a user gesture, but requiring fullscreen playback, should not be allowed to autoplay.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=155764
Bug Depends on: 155819    
Bug Blocks:    
Attachments:
Description Flags
Patch
darin: review+
Patch for landing none

Jer Noble
Reported 2016-03-17 14:44:36 PDT
Media elements allowed to play without a user gesture, but requiring fullscreen playback, should not be allowed to autoplay.
Attachments
Patch (1.74 KB, patch)
2016-03-17 14:47 PDT, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (3.51 KB, patch)
2016-03-18 11:15 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-03-17 14:47:52 PDT
Created attachment 274325 [details] Patch
Darin Adler
Comment 2 2016-03-17 23:52:58 PDT
Comment on attachment 274325 [details] Patch It’s unlikely this will all work well long term if we have no regression tests. Please figure out a way to write a regression test for this.
Jer Noble
Comment 3 2016-03-18 11:03:18 PDT
(In reply to comment #2) > Comment on attachment 274325 [details] > Patch > > It’s unlikely this will all work well long term if we have no regression > tests. Please figure out a way to write a regression test for this. Sure thing. I think it should be pretty easy, actually, to test this in LayoutTests.
Jer Noble
Comment 4 2016-03-18 11:15:48 PDT
Created attachment 274434 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-03-22 11:04:02 PDT
Comment on attachment 274434 [details] Patch for landing Clearing flags on attachment: 274434 Committed r198538: <http://trac.webkit.org/changeset/198538>
Alexey Proskuryakov
Comment 6 2016-03-23 17:09:50 PDT
This broke two tests on iOS Simulator: https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/4266/steps/run-api-tests/logs/stdio Will roll out, as discussed in person.
WebKit Commit Bot
Comment 7 2016-03-23 17:10:44 PDT
Re-opened since this is blocked by bug 155819
Alexey Proskuryakov
Comment 8 2016-03-23 17:21:48 PDT
Jer followed up explaining that a patch has already been posted elsewhere. I haven't seen it.
Jer Noble
Comment 9 2016-03-23 17:25:48 PDT
Alexey, you sent me a link to the bug on IRC.
Jer Noble
Comment 11 2016-03-23 17:43:43 PDT
Committed r198609: <http://trac.webkit.org/changeset/198609>
Note You need to log in before you can comment on or make changes to this bug.