Bug 155597

Summary: Web Inspector: Shallow size is misleading, prefer retained size in Heap Snapshot data grids
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Example 1
none
[IMAGE] Example 2 none

Joseph Pecoraro
Reported 2016-03-17 14:09:58 PDT
* SUMMARY Prefer retained size to the shallow size in Heap Snapshot data grids. • The self size of an instance is its own size. • The retained size of an instance is all of the memory that is retained by the object. - if the object were deleted, this would be the entire amount of memory freed - this includes: - size size - any dependent objects, owned exclusively by this instance Currently the data grid shows all Arrays as having the same, 16 byte self size. That isn't very useful as some Arrays exclusively hold onto other objects and thus should be treated as larger. Retained size is exactly the value we want here.
Attachments
[PATCH] Proposed Fix (12.62 KB, patch)
2016-03-17 15:24 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Example 1 (325.75 KB, image/png)
2016-03-17 15:28 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] Example 2 (257.37 KB, image/png)
2016-03-17 15:28 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-17 14:11:46 PDT
<rdar://problem/25225087>
Joseph Pecoraro
Comment 2 2016-03-17 15:24:08 PDT
Created attachment 274327 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-03-17 15:28:00 PDT
Created attachment 274329 [details] [IMAGE] Example 1
Joseph Pecoraro
Comment 4 2016-03-17 15:28:10 PDT
Created attachment 274330 [details] [IMAGE] Example 2
WebKit Commit Bot
Comment 5 2016-03-17 16:25:45 PDT
Comment on attachment 274327 [details] [PATCH] Proposed Fix Clearing flags on attachment: 274327 Committed r198358: <http://trac.webkit.org/changeset/198358>
WebKit Commit Bot
Comment 6 2016-03-17 16:25:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.