Bug 155593

Summary: [ES6] Getters and Setters should be prefixed appropriately
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2016-03-17 11:52:44 PDT
According to the ES6 spec, the names of getters and setters should have a "get " or "set ". This is true for the getters and setter defined in our static tables. Those that are created explicitly are currently don't have the prefixes.
Attachments
Patch (13.00 KB, patch)
2016-03-17 12:06 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-17 11:53:52 PDT
<rdar://problem/25221898>
Michael Saboff
Comment 2 2016-03-17 12:06:52 PDT
Created attachment 274309 [details] Patch
Mark Lam
Comment 3 2016-03-17 12:15:50 PDT
Comment on attachment 274309 [details] Patch r=me
Keith Miller
Comment 4 2016-03-17 12:18:18 PDT
Comment on attachment 274309 [details] Patch LGTM, JSObject::putDirectNativeIntrinsicGetter should only be used internally so adding the "get " should not be a problem.
WebKit Commit Bot
Comment 5 2016-03-17 13:13:23 PDT
Comment on attachment 274309 [details] Patch Clearing flags on attachment: 274309 Committed r198348: <http://trac.webkit.org/changeset/198348>
WebKit Commit Bot
Comment 6 2016-03-17 13:13:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.