Bug 155575

Summary: [ES6] Make GetProperty(.) inside ArrayPrototype.cpp spec compatible.
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
fpizlo: review+
perf is neutral none

Saam Barati
Reported 2016-03-16 19:24:15 PDT
...
Attachments
WIP (4.22 KB, patch)
2016-03-16 19:25 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (10.15 KB, patch)
2016-03-17 15:42 PDT, Saam Barati 		fpizlo: review+
DetailsFormatted DiffDiff
perf is neutral (65.84 KB, text/plain)
2016-03-17 16:50 PDT, Saam Barati 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-16 19:25:01 PDT
Created attachment 274254 [details] WIP I want to run perf numbers.
Saam Barati
Comment 2 2016-03-17 15:42:32 PDT
Created attachment 274333 [details] patch
Mark Lam
Comment 3 2016-03-17 15:51:43 PDT
Comment on attachment 274333 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=274333&action=review > Source/JavaScriptCore/ChangeLog:10 > + operation. Instead, they need to be performed as two distince operations typos: /distince/distinct/. > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:152 > + // We want perform get and has in the same operation. typo: /want perform/want to perform/. > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:154 > + // only time it is observable is when we encounter a ProxyObject Did you mean "when we didn't encounter"?
Saam Barati
Comment 4 2016-03-17 16:50:33 PDT
Created attachment 274340 [details] perf is neutral
Saam Barati
Comment 5 2016-03-17 16:55:49 PDT
http://trac.webkit.org/changeset/198360
Note You need to log in before you can comment on or make changes to this bug.