Bug 155574

Summary: [iOS] Allow clients to hide the accessory view on a form input session
Product: WebKit Reporter: Chelsea Pugh <cpugh>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: adele, commit-queue, cpugh, enrica, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Description Flags
patch v1
mitz: review+
patch v2 with name change none

Description Chelsea Pugh 2016-03-16 18:55:57 PDT
Allow clients to hide the accessory view on a form input session. Patch forthcoming.
Comment 1 Chelsea Pugh 2016-03-16 19:03:54 PDT
Created attachment 274253 [details]
patch v1
Comment 2 mitz 2016-03-16 22:18:28 PDT
Comment on attachment 274253 [details]
patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=274253&action=review


I am not setting cq+, in case you are inspired to change the name before committing this, but I’m fine with going with this name, and possibly changing it later.

> Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:45
> +@property (nonatomic) BOOL hidesAccessoryView WK_AVAILABLE(NA, WK_IOS_TBA);

This can be named better, but I don’t have a great suggestion. The things that I don’t like about this name are (a) an input session isn’t really a thing that hides (or shows) the accessory view (b) it’s strange to treat the accessory view as something that’s there by default and the input session can hide, but I understand how it would be misleading to name this property showsAccessoryView, because the accessory view isn’t shown for all input types.

Here’s a not-so-great suggestion:
    // Defaults to YES.
    @property BOOL accessoryViewMayShow;
Comment 3 Chelsea Pugh 2016-04-20 18:54:44 PDT
Created attachment 276882 [details]
patch v2 with name change
Comment 4 WebKit Commit Bot 2016-04-21 11:10:15 PDT
Comment on attachment 276882 [details]
patch v2 with name change

Clearing flags on attachment: 276882

Committed r199823: <http://trac.webkit.org/changeset/199823>
Comment 5 WebKit Commit Bot 2016-04-21 11:10:20 PDT
All reviewed patches have been landed.  Closing bug.