Bug 15556

Summary: REGRESSION: Fix last layout test failure (actually a crash) seen on trunk-mac-ppc-release
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, oliver
Priority: P1 Keywords: Regression
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch andersca: review+

Nikolas Zimmermann
Reported 2007-10-18 07:03:10 PDT
ImageBuffers aren't clipped against the visible frame size (RenderView). This leads to unnecessary large allocations, which may crash some machines in extreme cases like <mask width="10000".... As this worked at some point, before the ImageBuffer restructurization, this is actually a regression, so P1.
Attachments
Initial patch (9.87 KB, patch)
2007-10-18 07:06 PDT, Nikolas Zimmermann 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2007-10-18 07:06:29 PDT
Created attachment 16722 [details] Initial patch Attached patch fixes crash - but not only for mask, but any ImageBuffer based content (ie. patterns, gradient on text, etc.)
Nikolas Zimmermann
Comment 2 2007-10-18 07:19:20 PDT
*** Bug 15396 has been marked as a duplicate of this bug. ***
Anders Carlsson
Comment 3 2007-10-18 08:23:46 PDT
Comment on attachment 16722 [details] Initial patch r=me
Nikolas Zimmermann
Comment 4 2007-10-18 08:31:08 PDT
Landed in r26745.
David Kilzer (:ddkilzer)
Comment 5 2007-10-18 09:29:53 PDT
Regression per Comment #0.
Note You need to log in before you can comment on or make changes to this bug.