Bug 155558

Summary: Subpixel rendering: Directly composited image layers need pixelsnapping.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2016-03-16 13:47:45 PDT 
ssia.
Comment 1 zalan 2016-03-16 13:50:26 PDT 
Created attachment 274219 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-03-16 13:54:37 PDT 
Comment on attachment 274219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274219&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1551
> -            contentsClippingRect.move(contentOffsetInCompostingLayer());
> +            contentsClippingRect.move(snapSizeToDevicePixel(contentOffsetInCompostingLayer(), LayoutPoint(), deviceScaleFactor()));

Move then snap?

> LayoutTests/fast/images/hidpi-directly-composited-image-on-subpixel-position-expected.html:1
> +<!DOCTYPE>

<!DOCTYPE html>

> LayoutTests/fast/images/hidpi-directly-composited-image-on-subpixel-position.html:1
> +<!DOCTYPE>

<!DOCTYPE html>
Comment 3 zalan 2016-03-16 13:59:11 PDT 
Created attachment 274220 [details]
Patch
Comment 4 WebKit Commit Bot 2016-03-16 17:07:44 PDT 
Comment on attachment 274220 [details]
Patch

Clearing flags on attachment: 274220

Committed r198309: <http://trac.webkit.org/changeset/198309>
Comment 5 WebKit Commit Bot 2016-03-16 17:07:47 PDT 
All reviewed patches have been landed.  Closing bug.