Bug 155558 - Subpixel rendering: Directly composited image layers need pixelsnapping.
Summary: Subpixel rendering: Directly composited image layers need pixelsnapping.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-16 13:47 PDT by zalan
Modified: 2016-03-16 17:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.98 KB, patch)
2016-03-16 13:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.89 KB, patch)
2016-03-16 13:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-03-16 13:47:45 PDT 
ssia.
Comment 1 zalan 2016-03-16 13:50:26 PDT 
Created attachment 274219 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-03-16 13:54:37 PDT 
Comment on attachment 274219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274219&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1551
> -            contentsClippingRect.move(contentOffsetInCompostingLayer());
> +            contentsClippingRect.move(snapSizeToDevicePixel(contentOffsetInCompostingLayer(), LayoutPoint(), deviceScaleFactor()));

Move then snap?

> LayoutTests/fast/images/hidpi-directly-composited-image-on-subpixel-position-expected.html:1
> +<!DOCTYPE>

<!DOCTYPE html>

> LayoutTests/fast/images/hidpi-directly-composited-image-on-subpixel-position.html:1
> +<!DOCTYPE>

<!DOCTYPE html>
Comment 3 zalan 2016-03-16 13:59:11 PDT 
Created attachment 274220 [details]
Patch
Comment 4 WebKit Commit Bot 2016-03-16 17:07:44 PDT 
Comment on attachment 274220 [details]
Patch

Clearing flags on attachment: 274220

Committed r198309: <http://trac.webkit.org/changeset/198309>
Comment 5 WebKit Commit Bot 2016-03-16 17:07:47 PDT 
All reviewed patches have been landed.  Closing bug.