Bug 155550

Summary: REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tim Horton 2016-03-16 11:26:06 PDT 
Need to keep _setDrawsTransparentBackground: around and working for now
Comment 1 Tim Horton 2016-03-16 11:33:19 PDT 
Created attachment 274201 [details]
Patch
Comment 2 mitz 2016-03-16 11:35:14 PDT 
Comment on attachment 274201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review

> Source/WebKit2/ChangeLog:3
> +        Need to keep _setDrawsTransparentBackground: around and working for now

A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank”
Comment 3 mitz 2016-03-16 11:36:12 PDT 
Comment on attachment 274201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188
> +    static bool hasLoggedDeprecationWarning;

Strange mix of C bool…

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191
> +        hasLoggedDeprecationWarning = YES;

…with Objective-C YES.
Comment 4 Tim Horton 2016-03-16 11:37:59 PDT 
Comment on attachment 274201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review

>> Source/WebKit2/ChangeLog:3
>> +        Need to keep _setDrawsTransparentBackground: around and working for now
> 
> A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank”

OK!

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191
>> +        hasLoggedDeprecationWarning = YES;
> 
> …with Objective-C YES.

Fair!
Comment 5 Tim Horton 2016-03-16 11:40:45 PDT 
Created attachment 274202 [details]
Patch
Comment 6 mitz 2016-03-16 11:42:31 PDT 
Comment on attachment 274202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274202&action=review

> Source/WebKit2/ChangeLog:8
> +

Might be useful to explain here how this fixes the bug.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188
> +    static BOOL hasLoggedDeprecationWarning;

Would be good to have a comment referencing this bug here so that people can easily answer the question why this is here and whether it’s OK to remove it.
Comment 7 Tim Horton 2016-03-16 12:15:07 PDT 
Created attachment 274207 [details]
Patch
Comment 8 WebKit Commit Bot 2016-03-16 13:16:46 PDT 
Comment on attachment 274207 [details]
Patch

Clearing flags on attachment: 274207

Committed r198298: <http://trac.webkit.org/changeset/198298>
Comment 9 WebKit Commit Bot 2016-03-16 13:16:50 PDT 
All reviewed patches have been landed.  Closing bug.