Bug 155542

Summary: Add support for movablelimits
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan, mrobinson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 133845    
Bug Blocks: 118737    
Attachments:
Description Flags
Patch (WIP)
none
testcase
none
testcase
none
Patch
none
Patch
none
Patch
none
Patch none

Description Frédéric Wang (:fredw) 2016-03-16 08:08:39 PDT
Created attachment 274190 [details]
Patch (WIP)

When the base of an munderover/munder/mover element is an operator with the movablelimits=true property in displaystyle=false ; it should render the same as the equivalent msubsup/msub/sup. After the MathML refactoring, it is easy: we essentially need to make RenderMathMLUnderOver inherits from RenderMathMLScripts. This actually allows to share more code between the two classes.

I'm attaching a WIP patch. I plan to add new tests and to test it on mac too tomorrow.
Comment 1 Frédéric Wang (:fredw) 2016-03-16 08:09:06 PDT
Created attachment 274191 [details]
testcase
Comment 2 Frédéric Wang (:fredw) 2016-03-16 08:09:52 PDT
Created attachment 274192 [details]
testcase
Comment 3 Frédéric Wang (:fredw) 2016-03-17 01:29:06 PDT
Created attachment 274270 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2016-04-26 09:01:47 PDT
Created attachment 277379 [details]
Patch
Comment 5 Frédéric Wang (:fredw) 2016-06-25 00:38:30 PDT
Created attachment 282053 [details]
Patch
Comment 6 Brent Fulgham 2016-07-07 14:05:28 PDT
Comment on attachment 282053 [details]
Patch

These changes seem okay. Please confirm tests pass with these updates in place before landing.
Comment 7 Frédéric Wang (:fredw) 2016-07-07 23:04:31 PDT
Created attachment 283111 [details]
Patch
Comment 8 Frédéric Wang (:fredw) 2016-07-08 00:16:09 PDT
Committed r202970: <http://trac.webkit.org/changeset/202970>