Bug 155512

Summary: [JSC] Help clang generate better code on arrayProtoFuncToString()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Patch none

Benjamin Poulain
Reported 2016-03-15 14:16:28 PDT
[JSC] Help clang generate better code on arrayProtoFuncToString()
Attachments
Patch (8.82 KB, patch)
2016-03-15 14:28 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-yosemite (962.76 KB, application/zip)
2016-03-15 15:31 PDT, Build Bot 		no flags
Details
Patch (8.88 KB, patch)
2016-03-15 17:15 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-03-15 14:28:54 PDT
Created attachment 274129 [details] Patch
Benjamin Poulain
Comment 2 2016-03-15 14:35:31 PDT
Uh, that removed 12k from the binary. That's probably the changes in jsMakeNontrivialString().
Mark Lam
Comment 3 2016-03-15 14:38:39 PDT
Comment on attachment 274129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274129&action=review r=me > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:327 > - if (exec->hadException()) > + if (UNLIKELY(exec->hadException())) Let's cache the VM above and use vm.exception() in the check here and below.
Build Bot
Comment 4 2016-03-15 15:31:40 PDT
Comment on attachment 274129 [details] Patch Attachment 274129 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/985303 New failing tests: js/function-call-aliased.html
Build Bot
Comment 5 2016-03-15 15:31:42 PDT
Created attachment 274146 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Benjamin Poulain
Comment 6 2016-03-15 17:15:58 PDT
Created attachment 274161 [details] Patch
WebKit Commit Bot
Comment 7 2016-03-15 19:16:26 PDT
Comment on attachment 274161 [details] Patch Clearing flags on attachment: 274161 Committed r198256: <http://trac.webkit.org/changeset/198256>
WebKit Commit Bot
Comment 8 2016-03-15 19:16:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.