Bug 155463

Summary: [WinCairo] Compile fix.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, japhet, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

peavo
Reported 2016-03-14 14:15:28 PDT
We need to provide a session id when constructing a NetworkStorageSession object.
Attachments
Patch (1.36 KB, patch)
2016-03-14 14:22 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (3.60 KB, patch)
2016-03-14 15:57 PDT, peavo 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2016-03-14 14:22:03 PDT
Created attachment 274027 [details] Patch
Alex Christensen
Comment 2 2016-03-14 14:31:54 PDT
Is there a way we could use the same LOCAL_SESSION definition as everyone else in WinCairo?
peavo
Comment 3 2016-03-14 14:51:17 PDT
(In reply to comment #2) > Is there a way we could use the same LOCAL_SESSION definition as everyone > else in WinCairo? Yes, I think so. I will look into it :)
peavo
Comment 4 2016-03-14 15:57:16 PDT
Created attachment 274045 [details] Patch
Alex Christensen
Comment 5 2016-03-14 21:51:26 PDT
Comment on attachment 274045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274045&action=review Ahhh, that feels so much better. > Source/WebCore/loader/CookieJar.cpp:56 > #define LOCAL_SESSION(document) NetworkStorageSession& session = storageSession(document); We could probably even get rid of this, too. auto session = storageSession(document)
Alex Christensen
Comment 6 2016-03-14 21:59:51 PDT
http://trac.webkit.org/changeset/198195
Alex Christensen
Comment 7 2016-03-14 22:26:06 PDT
Cleanup in https://bugs.webkit.org/show_bug.cgi?id=155484
Alex Christensen
Comment 8 2016-03-14 22:32:51 PDT
Build fix in http://trac.webkit.org/changeset/198197
peavo
Comment 9 2016-03-15 09:57:23 PDT
Thank you!
Note You need to log in before you can comment on or make changes to this bug.