Bug 155463

Summary: [WinCairo] Compile fix.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, japhet, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Description peavo 2016-03-14 14:15:28 PDT 
We need to provide a session id when constructing a NetworkStorageSession object.
Comment 1 peavo 2016-03-14 14:22:03 PDT 
Created attachment 274027 [details]
Patch
Comment 2 Alex Christensen 2016-03-14 14:31:54 PDT 
Is there a way we could use the same LOCAL_SESSION definition as everyone else in WinCairo?
Comment 3 peavo 2016-03-14 14:51:17 PDT 
(In reply to comment #2)
> Is there a way we could use the same LOCAL_SESSION definition as everyone
> else in WinCairo?

Yes, I think so. I will look into it :)
Comment 4 peavo 2016-03-14 15:57:16 PDT 
Created attachment 274045 [details]
Patch
Comment 5 Alex Christensen 2016-03-14 21:51:26 PDT 
Comment on attachment 274045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274045&action=review

Ahhh, that feels so much better.

> Source/WebCore/loader/CookieJar.cpp:56
>  #define LOCAL_SESSION(document) NetworkStorageSession& session = storageSession(document);

We could probably even get rid of this, too.  auto session = storageSession(document)
Comment 6 Alex Christensen 2016-03-14 21:59:51 PDT 
http://trac.webkit.org/changeset/198195
Comment 7 Alex Christensen 2016-03-14 22:26:06 PDT 
Cleanup in https://bugs.webkit.org/show_bug.cgi?id=155484
Comment 8 Alex Christensen 2016-03-14 22:32:51 PDT 
Build fix in http://trac.webkit.org/changeset/198197
Comment 9 peavo 2016-03-15 09:57:23 PDT 
Thank you!