Bug 155451

Summary: [ES6] Disallow var assignments in for-in loops
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 155518, 159478    
Bug Blocks:    
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2016-03-14 11:54:19 PDT
This is what the spec dictates, but last time we made this change, some websites that we care about broke. Lets try making it again, and if things break we will roll it out.
Attachments
patch (6.28 KB, patch)
2016-03-14 12:02 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (6.32 KB, patch)
2016-03-30 16:02 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-14 12:02:18 PDT
Created attachment 273998 [details] patch
Mark Lam
Comment 2 2016-03-14 12:04:09 PDT
Comment on attachment 273998 [details] patch r=me
Saam Barati
Comment 3 2016-03-14 12:40:05 PDT
landed in: http://trac.webkit.org/changeset/198148
WebKit Commit Bot
Comment 4 2016-03-15 15:35:57 PDT
Re-opened since this is blocked by bug 155518
Saam Barati
Comment 5 2016-03-30 16:02:20 PDT
Created attachment 275231 [details] patch for landing
WebKit Commit Bot
Comment 6 2016-03-31 16:07:37 PDT
Comment on attachment 275231 [details] patch for landing Clearing flags on attachment: 275231 Committed r198928: <http://trac.webkit.org/changeset/198928>
WebKit Commit Bot
Comment 7 2016-03-31 16:07:43 PDT
All reviewed patches have been landed. Closing bug.
Yusuke Suzuki
Comment 8 2016-04-03 09:50:59 PDT
Committed r198985: <http://trac.webkit.org/changeset/198985>
WebKit Commit Bot
Comment 9 2016-07-06 11:19:52 PDT
Re-opened since this is blocked by bug 159478
Saam Barati
Comment 10 2016-07-06 11:32:34 PDT
This breaks websites, so we're not going to land it
Note You need to log in before you can comment on or make changes to this bug.