Summary: | Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, joepeck, saam, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-03-13 18:48:37 PDT
Created attachment 273915 [details]
[PATCH] Proposed Fix
Attachment 273915 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0: Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py. [featuredefines/new] [5]
Total errors found: 2 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273915 [details]
[PATCH] Proposed Fix
r=me!
Comment on attachment 273915 [details] [PATCH] Proposed Fix Rejecting attachment 273915 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 273915, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/974002 Comment on attachment 273915 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=273915&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Let's drop this line. Created attachment 273920 [details]
[PATCH] Proposed Fix
Comment on attachment 273920 [details] [PATCH] Proposed Fix Clearing flags on attachment: 273920 Committed r198093: <http://trac.webkit.org/changeset/198093> |