Bug 155379

Summary: [Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cmarcelo, commit-queue, darin, jamesr, luiz, thorton, tonikitoo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bdakin: review+, commit-queue: commit-queue-

Myles C. Maxfield
Reported 2016-03-11 14:24:01 PST
[Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter
Attachments
Patch (41.60 KB, patch)
2016-03-11 14:25 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (41.44 KB, patch)
2016-03-11 23:39 PST, Myles C. Maxfield 		bdakin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-03-11 14:25:20 PST
Created attachment 273768 [details] Patch
Beth Dakin
Comment 2 2016-03-11 17:29:25 PST
Comment on attachment 273768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273768&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.h:43 > +typedef id ScrollerImpController; I think that you should either not change these at all, or you should change these to the real names too: ScrollbarPainterController -> NSScrollerImpPair The same is probably true for the delegate.
Myles C. Maxfield
Comment 3 2016-03-11 23:39:48 PST
Created attachment 273817 [details] Patch
WebKit Commit Bot
Comment 4 2016-03-12 15:47:17 PST
Comment on attachment 273817 [details] Patch Rejecting attachment 273817 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 273817, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/968357
Myles C. Maxfield
Comment 5 2016-03-12 19:58:29 PST
Committed r198078: <http://trac.webkit.org/changeset/198078>
Note You need to log in before you can comment on or make changes to this bug.