Bug 155379

Summary: [Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cmarcelo, commit-queue, darin, jamesr, luiz, thorton, tonikitoo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bdakin: review+, commit-queue: commit-queue-

Description Myles C. Maxfield 2016-03-11 14:24:01 PST
[Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter
Comment 1 Myles C. Maxfield 2016-03-11 14:25:20 PST
Created attachment 273768 [details]
Patch
Comment 2 Beth Dakin 2016-03-11 17:29:25 PST
Comment on attachment 273768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273768&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:43
> +typedef id ScrollerImpController;

I think that you should either not change these at all, or you should change these to the real names too:
ScrollbarPainterController -> NSScrollerImpPair

The same is probably true for the delegate.
Comment 3 Myles C. Maxfield 2016-03-11 23:39:48 PST
Created attachment 273817 [details]
Patch
Comment 4 WebKit Commit Bot 2016-03-12 15:47:17 PST
Comment on attachment 273817 [details]
Patch

Rejecting attachment 273817 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 273817, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/968357
Comment 5 Myles C. Maxfield 2016-03-12 19:58:29 PST
Committed r198078: <http://trac.webkit.org/changeset/198078>