Bug 155374

Summary: [AX] SVG element with child desc not exposed
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Joanmarie Diggs 2016-03-11 11:43:59 PST 
[AX] SVG element with child desc not exposed
Comment 1 Joanmarie Diggs 2016-03-11 11:48:05 PST 
Created attachment 273750 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-03-11 11:49:23 PST 
<rdar://problem/25114469>
Comment 3 Darin Adler 2016-03-11 13:56:11 PST 
Comment on attachment 273750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273750&action=review

> Source/WebCore/accessibility/AccessibilitySVGElement.h:35
> +class AccessibilitySVGElement : public AccessibilityRenderObject {

Since the class is no longer final, best practice would be to mark the overrides of virtual functions here final, instead of override, unless we need to override them further in the derived class.

I believe that’s true for *all* the override functions in this class.

Further, everything in this class except the constructor that is currently protected seems like it should be private instead.
Comment 4 Joanmarie Diggs 2016-03-14 08:33:34 PDT 
Created attachment 273979 [details]
Patch
Comment 5 Joanmarie Diggs 2016-03-14 09:22:18 PDT 
@Darin: Changes made. Thanks for the review!

@Chris: Accessibility sanity check? :)
Comment 6 chris fleizach 2016-03-14 09:25:28 PDT 
(In reply to comment #5)
> @Darin: Changes made. Thanks for the review!
> 
> @Chris: Accessibility sanity check? :)

LGTM
Comment 7 WebKit Commit Bot 2016-03-14 10:18:40 PDT 
Comment on attachment 273979 [details]
Patch

Clearing flags on attachment: 273979

Committed r198137: <http://trac.webkit.org/changeset/198137>
Comment 8 WebKit Commit Bot 2016-03-14 10:18:44 PDT 
All reviewed patches have been landed.  Closing bug.