Summary: | Enable GSS-Negotiate support in libsoup | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tomas Popela <tpopela> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ab, berto, bugs-noreply, cgarcia, commit-queue, danw, gustavo, mcatanzaro, mrobinson | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tomas Popela
2016-03-11 02:07:02 PST
Created attachment 273713 [details]
Patch
Avoiding commit queue as it will be better to land this manually, once the Dan will commit the libsoup change.
Comment on attachment 273713 [details] Patch Attachment 273713 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/960357 New failing tests: js/function-apply.html Created attachment 273721 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 273713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273713&action=review I didn't realize this way landing for 3.20. Yippee. :) Please leave a comment once this lands in libsoup; we'll want to wait for that before committing. > Source/WebCore/ChangeLog:8 > + Enable the SOUP_TYPE_AUTH_NEGOTIATE feature inf libsoup was compiled if > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:114 > + if (soup_auth_negotiate_supported) { Nit: not sure if this makes any difference, but maybe would be better beneath the call to setupLogger? (In reply to comment #4) > > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:114 > > + if (soup_auth_negotiate_supported) { > > Nit: not sure if this makes any difference, but maybe would be better > beneath the call to setupLogger? I don't think it makes any difference, I will leave it as it is. Created attachment 273970 [details] Patch Updated patch to reflect latest changes and typo in the changelog. The libsoup part is already done with https://git.gnome.org/browse/libsoup/commit/?id=6a8826f0d25459c943719b88f22619f22b81c547 . Comment on attachment 273970 [details] Patch Clearing flags on attachment: 273970 Committed r198127: <http://trac.webkit.org/changeset/198127> All reviewed patches have been landed. Closing bug. |