| Summary: | Expose additional WKDataDetectorTypes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||||
| Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer, ryanhaddad, sam, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Enrica Casucci
2016-03-10 15:22:02 PST
Created attachment 273635 [details]
Patch
Attachment 273635 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273635 [details]
Patch
I think we need some naming changes here. Will discuss offline.
Created attachment 273653 [details]
Patch2
Attachment 273653 [details] did not pass style-queue:
ERROR: Source/WebCore/editing/cocoa/DataDetection.mm:47: *SoftLink.h header should be included after all other headers. [build/include_order] [4]
ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed revision 197976. This change broke Mac and iOS builds <https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20%28Build%29/builds/4426> <https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/4356> (In reply to comment #7) > This change broke Mac and iOS builds > > <https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Release%20%28Build%29/builds/4426> > <https://build.webkit.org/builders/ > Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/4356> Committed r197977: <http://trac.webkit.org/r197977> Additional fix for internal iOS 9.x SDK builds: Committed r197992: <http://trac.webkit.org/r197992> (In reply to comment #8) > (In reply to comment #7) > > This change broke Mac and iOS builds > > > > <https://build.webkit.org/builders/ > > Apple%20El%20Capitan%20Release%20%28Build%29/builds/4426> > > <https://build.webkit.org/builders/ > > Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/4356> > > Committed r197977: <http://trac.webkit.org/r197977> > > Additional fix for internal iOS 9.x SDK builds: > > Committed r197992: <http://trac.webkit.org/r197992> I don't think that will fix anything by itself; I landed 197993 on top of it which should actually fix. (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > This change broke Mac and iOS builds > > > > > > <https://build.webkit.org/builders/ > > > Apple%20El%20Capitan%20Release%20%28Build%29/builds/4426> > > > <https://build.webkit.org/builders/ > > > Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/4356> > > > > Committed r197977: <http://trac.webkit.org/r197977> > > > > Additional fix for internal iOS 9.x SDK builds: > > > > Committed r197992: <http://trac.webkit.org/r197992> > > I don't think that will fix anything by itself; I landed 197993 on top of it > which should actually fix. Yes, it wasn't a complete fix in hindsight; only addressed the missing DDOptionalSource.h header error. Thanks Tim! |