Bug 155318

Summary: Web Inspector: TreeOutlineDataGridSynchronizer should be optional in TimelineDataGrid
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 153036    
Attachments:
Description Flags
[Patch] Proposed Fix none

Matt Baker
Reported 2016-03-10 12:44:49 PST
* SUMMARY TreeOutlineDataGridSynchronizer should be optional in TimelineDataGrid. TimelineViews no longer use tree outlines, but the synchronizer still needs to be supported since the Network tab uses a TimelineDataGrid. For clients of TimelineDataGrid, the only change is to TimelineDataGrid.addRowInSortOrder: TimelineDataGrid.prototype.addRowInSortOrder(treeElement, dataGridNode, parentTreeElementOrDataGridNode) - treeElement: optional, TimelineView's will pass null. - parentTreeElementOrDataGridNode: overloaded parameter. TimelineViews will pass a DataGridNode instead of a tree element.
Attachments
[Patch] Proposed Fix (9.89 KB, patch)
2016-03-10 12:54 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-10 12:45:05 PST
<rdar://problem/25091949>
Matt Baker
Comment 2 2016-03-10 12:54:22 PST
Created attachment 273603 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 3 2016-03-10 14:58:18 PST
Comment on attachment 273603 [details] [Patch] Proposed Fix Clearing flags on attachment: 273603 Committed r197958: <http://trac.webkit.org/changeset/197958>
WebKit Commit Bot
Comment 4 2016-03-10 14:58:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.