We currently update the render tree as we resolve style. If we need to create new renderers we enter a different code path that replicates much of the style resolve code. Making style resolve and render tree updating two separate operations will clean up the code and enable future improvements.
Created attachment 273574[details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Attachment 273829[details] did not pass style-queue:
ERROR: Source/WebCore/style/StyleSharingResolver.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 273832[details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Attachment 273835[details] did not pass style-queue:
ERROR: Source/WebCore/style/StyleSharingResolver.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 273858[details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273884[details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273885[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 273886[details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 273887[details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273937[details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273938[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 273939[details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 273942[details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273959[details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273960[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 273961[details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 273963[details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273976[details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273977[details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 273978[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 273982[details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 274410[details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 274411[details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 274412[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 274413[details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 274584[details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 274586[details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 274588[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 274595[details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 274734[details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 274735[details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 274736[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 274738[details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 274983[details]
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=274983&action=review
r=me
> Source/WebCore/style/RenderTreeUpdater.cpp:117
> + // FIXME: SVG <use> element may cause tree mutations during style recalc.
This would be nice to get fixed, then.
> Source/WebCore/style/StyleUpdate.cpp:48
> + auto it = m_elements.find(&element);
> + if (it == m_elements.end())
> + return nullptr;
> + return &it->value;
I suppose this could just be "m_elements.get(&element);"
Created attachment 275317[details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 275318[details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 275320[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 275323[details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
2016-03-10 08:06 PST, Antti Koivisto
2016-03-10 08:16 PST, Antti Koivisto
2016-03-10 09:18 PST, Build Bot
2016-03-12 01:54 PST, Antti Koivisto
2016-03-12 02:37 PST, Antti Koivisto
2016-03-12 03:23 PST, Build Bot
2016-03-12 06:48 PST, Antti Koivisto
2016-03-12 16:02 PST, Build Bot
2016-03-12 23:44 PST, Antti Koivisto
2016-03-12 23:56 PST, Antti Koivisto
2016-03-13 00:26 PST, Antti Koivisto
2016-03-13 01:12 PST, Antti Koivisto
2016-03-13 03:10 PDT, Build Bot
2016-03-13 03:15 PDT, Build Bot
2016-03-13 03:16 PDT, Build Bot
2016-03-13 03:17 PDT, Build Bot
2016-03-14 00:23 PDT, Antti Koivisto
2016-03-14 01:20 PDT, Build Bot
2016-03-14 01:34 PDT, Build Bot
2016-03-14 01:35 PDT, Build Bot
2016-03-14 01:54 PDT, Build Bot
2016-03-14 03:09 PDT, Antti Koivisto
2016-03-14 04:03 PDT, Antti Koivisto
2016-03-14 05:01 PDT, Build Bot
2016-03-14 05:04 PDT, Build Bot
2016-03-14 05:05 PDT, Build Bot
2016-03-14 05:36 PDT, Build Bot
2016-03-14 07:08 PDT, Antti Koivisto
2016-03-14 08:28 PDT, Build Bot
2016-03-14 08:31 PDT, Build Bot
2016-03-14 08:33 PDT, Build Bot
2016-03-14 08:53 PDT, Build Bot
2016-03-18 06:18 PDT, Antti Koivisto
2016-03-18 07:11 PDT, Build Bot
2016-03-18 07:17 PDT, Build Bot
2016-03-18 07:19 PDT, Build Bot
2016-03-18 07:28 PDT, Build Bot
2016-03-21 06:00 PDT, Antti Koivisto
2016-03-21 06:54 PDT, Build Bot
2016-03-21 07:00 PDT, Build Bot
2016-03-21 07:01 PDT, Build Bot
2016-03-21 07:30 PDT, Build Bot
2016-03-22 23:59 PDT, Antti Koivisto
2016-03-23 00:52 PDT, Build Bot
2016-03-23 00:55 PDT, Build Bot
2016-03-23 00:59 PDT, Build Bot
2016-03-23 01:08 PDT, Antti Koivisto
2016-03-23 01:08 PDT, Build Bot
2016-03-25 03:05 PDT, Antti Koivisto
2016-03-26 06:34 PDT, Antti Koivisto
2016-03-31 12:39 PDT, Antti Koivisto
2016-03-31 13:32 PDT, Build Bot
2016-03-31 13:35 PDT, Build Bot
2016-03-31 13:41 PDT, Build Bot
2016-03-31 14:00 PDT, Build Bot
2016-04-01 00:09 PDT, Antti Koivisto
2016-04-01 00:33 PDT, Antti Koivisto