Bug 155265

Summary: Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, bfulgham, it, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=155185
Bug Depends on: 155185    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Brent Fulgham 2016-03-09 14:59:01 PST 
Several tests break with <http://trac.webkit.org/changeset/197870> because code that sets the "allowFileAccessFromFileURLs" are getting blocked due to a disconnect between two flags on two different preference/configuration objects.

Temporarily encode "YES" as the default state for "_allowUniversalAccessFromFileURLs" to work around this, since we can't cleanly roll the patch out.

These tests break with the default "NO" state:


+fast/loader/stateobjects/replacestate-in-iframe.html
+storage/domstorage/localstorage/access-storage-after-window-close.html
+storage/domstorage/localstorage/access-storage-then-set-value-in-storage-after-window-close.html
+storage/domstorage/localstorage/set-value-in-storage-after-window-close.html
+storage/domstorage/localstorage/window-open.html
+storage/domstorage/sessionstorage/window-open.html
Comment 1 Brent Fulgham 2016-03-09 17:55:03 PST 
Temporary workaround landed in <http://trac.webkit.org/changeset/197889>.
Comment 2 Brent Fulgham 2016-03-09 18:00:01 PST 
Created attachment 273524 [details]
Patch
Comment 3 Andy Estes 2016-03-09 19:06:52 PST 
Comment on attachment 273524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273524&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:375
> +    configuration.get()._allowUniversalAccessFromFileURLs = YES;

[configuration _setAllowUniversalAccessFromFileURLs:YES];
Comment 4 Brent Fulgham 2016-03-09 20:03:06 PST 
Created attachment 273539 [details]
Patch
Comment 5 Brent Fulgham 2016-03-09 20:06:38 PST 
Committed r197920: <http://trac.webkit.org/changeset/197920>
Comment 6 Brent Fulgham 2016-03-10 08:40:48 PST 
<rdar://problem/25071049>
Comment 7 Brent Fulgham 2016-03-14 12:18:58 PDT 
*** Bug 155441 has been marked as a duplicate of this bug. ***