Bug 155248

Summary:

Add dumping of function expression names in CodeBlock bytecode dump.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

REOPENED

Severity:

Normal

CC:

benjamin, commit-queue, fpizlo, ggaren, keith_miller, msaboff, saam

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
proposed patch.	fpizlo: review-
proposed patch: only dump extra info if not in compiler thread.	fpizlo: review+

Mark Lam

Reported 2016-03-09 12:08:42 PST

Because ... [ 19] new_func_exp loc5, loc3, f0:foo ... is more informative than [ 19] new_func_exp loc5, loc3, f0 Patch coming soon.

Attachments
proposed patch. (4.88 KB, patch) 2016-03-09 12:13 PST, Mark Lam	fpizlo: review-	Details Formatted Diff Diff
proposed patch: only dump extra info if not in compiler thread. (4.95 KB, patch) 2016-03-09 12:32 PST, Mark Lam	fpizlo: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2016-03-09 12:13:34 PST

Filip Pizlo

Comment 2 2016-03-09 12:23:27 PST

Comment on attachment 273455 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=273455&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:772 > + String name = executable->inferredName().string(); This will not work on the concurrent JIT thread.

Mark Lam

Comment 3 2016-03-09 12:32:21 PST

Created attachment 273461 [details] proposed patch: only dump extra info if not in compiler thread.

Mark Lam

Comment 4 2016-03-09 12:36:57 PST

Thanks for the review. Landed in r197873: <http://trac.webkit.org/r197873>.

WebKit Commit Bot

Comment 5 2016-03-09 14:31:32 PST

Re-opened since this is blocked by bug 155262

Note You need to log in before you can comment on or make changes to this bug.