Bug 155244

Summary:

Rename WebCore/platform/crypto/mac/CryptoDigestMac.cpp to WebCore/platform/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Daniel Bates

Reported 2016-03-09 11:37:12 PST

We should rename WebCore/platform/crypto/mac/CryptoDigestMac.cpp to WebCore/platform/crypto/cocoa/CryptoDigestCocoa.cpp since this file can be used on both iOS and OS X.

Attachments
Patch (19.78 KB, patch) 2016-03-09 11:39 PST, Daniel Bates	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2016-03-09 11:39:51 PST

Created attachment 273448 [details] Patch

Daniel Bates

Comment 2 2016-03-09 11:40:54 PST

Comment on attachment 273448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273448&action=review > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). > + * PlatformMac.cmake: Will add an empty line between these two lines before landing.

Alexey Proskuryakov

Comment 3 2016-03-09 11:49:01 PST

Comment on attachment 273448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273448&action=review > Source/WebCore/ChangeLog:7 > + The file WebCore/platform/crypto/mac/CryptoDigestMac.cpp is applicable to both iOS and OS X. > + We should move and rename this file to reflect that is applicable to both of these platforms. This is a slight improvement, although possibly not the best name. This file does not use Cocoa.

Daniel Bates

Comment 4 2016-03-09 12:17:04 PST

(In reply to comment #3) > Comment on attachment 273448 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273448&action=review > > > Source/WebCore/ChangeLog:7 > > + The file WebCore/platform/crypto/mac/CryptoDigestMac.cpp is applicable to both iOS and OS X. > > + We should move and rename this file to reflect that is applicable to both of these platforms. > > This is a slight improvement, although possibly not the best name. This file > does not use Cocoa. As per our conversation on IRC today, will rename file WebCore/platform/crypto/mac/CryptoDigestMac.cpp to WebCore/platform/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp before landing.

Daniel Bates

Comment 5 2016-03-09 12:25:16 PST

Committed r197871: <http://trac.webkit.org/changeset/197871>

Note You need to log in before you can comment on or make changes to this bug.