Bug 155239

Summary: Add a getter for WebVideoFullscreenInterfaceObjC and update its rate property
Product: WebKit Reporter: Ada Chan <adachan>
Component: MediaAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Description Ada Chan 2016-03-09 10:17:54 PST 
Add a getter for WebVideoFullscreenInterfaceObjC and update its rate property.

Also move the stub for WebVideoFullscreenInterfaceMac::setVideoDimensions() to the mm file.
Comment 1 Ada Chan 2016-03-09 10:20:11 PST 
Needed for <rdar://problem/24396552>, <rdar://problem/24396678>, and <rdar://problem/24801763>.
Comment 2 Ada Chan 2016-03-09 11:28:11 PST 
Created attachment 273446 [details]
Patch
Comment 3 Eric Carlson 2016-03-09 14:01:51 PST 
Comment on attachment 273446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273446&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h:69
> +    WEBCORE_EXPORT void setVideoDimensions(bool hasVideo, float width, float height) override;

Nit: if this class isn't sub-classed, "override" should be "final"
Comment 4 Ada Chan 2016-03-09 14:25:36 PST 
(In reply to comment #3)
> Comment on attachment 273446 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273446&action=review
> 
> > Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h:69
> > +    WEBCORE_EXPORT void setVideoDimensions(bool hasVideo, float width, float height) override;
> 
> Nit: if this class isn't sub-classed, "override" should be "final"

Fixed.  Thanks for the review!
Comment 5 Ada Chan 2016-03-09 15:36:50 PST 
Committed:
http://trac.webkit.org/changeset/197893