Bug 155239 - Add a getter for WebVideoFullscreenInterfaceObjC and update its rate property
Summary: Add a getter for WebVideoFullscreenInterfaceObjC and update its rate property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-09 10:17 PST by Ada Chan
Modified: 2016-03-09 15:36 PST (History)
0 users

See Also:


Attachments
Patch (3.63 KB, patch)
2016-03-09 11:28 PST, Ada Chan
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-03-09 10:17:54 PST
Add a getter for WebVideoFullscreenInterfaceObjC and update its rate property.

Also move the stub for WebVideoFullscreenInterfaceMac::setVideoDimensions() to the mm file.
Comment 1 Ada Chan 2016-03-09 10:20:11 PST
Needed for <rdar://problem/24396552>, <rdar://problem/24396678>, and <rdar://problem/24801763>.
Comment 2 Ada Chan 2016-03-09 11:28:11 PST
Created attachment 273446 [details]
Patch
Comment 3 Eric Carlson 2016-03-09 14:01:51 PST
Comment on attachment 273446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273446&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h:69
> +    WEBCORE_EXPORT void setVideoDimensions(bool hasVideo, float width, float height) override;

Nit: if this class isn't sub-classed, "override" should be "final"
Comment 4 Ada Chan 2016-03-09 14:25:36 PST
(In reply to comment #3)
> Comment on attachment 273446 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273446&action=review
> 
> > Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h:69
> > +    WEBCORE_EXPORT void setVideoDimensions(bool hasVideo, float width, float height) override;
> 
> Nit: if this class isn't sub-classed, "override" should be "final"

Fixed.  Thanks for the review!
Comment 5 Ada Chan 2016-03-09 15:36:50 PST
Committed:
http://trac.webkit.org/changeset/197893