Bug 155231

Summary: Move attributes to the instance for most interfaces that have "Error" in their name
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, darin, oliver, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch none

Chris Dumez
Reported 2016-03-09 08:07:32 PST
Move attributes to the instance for most interfaces that have "Error" in their name.
Attachments
Patch (6.12 KB, patch)
2016-03-09 08:13 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (719.92 KB, application/zip)
2016-03-09 09:10 PST, Build Bot 		no flags
Details
Patch (9.58 KB, patch)
2016-03-09 11:45 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-03-09 08:13:02 PST
Created attachment 273428 [details] Patch
Build Bot
Comment 2 2016-03-09 09:10:47 PST
Comment on attachment 273428 [details] Patch Attachment 273428 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/948085 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html
Build Bot
Comment 3 2016-03-09 09:10:51 PST
Created attachment 273434 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Darin Adler
Comment 4 2016-03-09 09:59:18 PST
Comment on attachment 273428 [details] Patch Need to fix iOS expected results too?
Darin Adler
Comment 5 2016-03-09 09:59:57 PST
Comment on attachment 273428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273428&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:676 > # FIXME: These two should be fixed by removing the custom override of message, etc This comment no longer makes sense. It says “these two” but there are not two any more. It’s also unnecessarily vague. Would be better if it said something brief but a bit more specific.
Chris Dumez
Comment 6 2016-03-09 11:45:46 PST
Created attachment 273449 [details] Patch
WebKit Commit Bot
Comment 7 2016-03-09 12:37:25 PST
Comment on attachment 273449 [details] Patch Clearing flags on attachment: 273449 Committed r197874: <http://trac.webkit.org/changeset/197874>
WebKit Commit Bot
Comment 8 2016-03-09 12:37:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.