| Summary: | Rename Node.treeRoot to rootNode and turn it on by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, kling, koivisto, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 148695 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2016-03-09 01:49:19 PST
Created attachment 273415 [details]
Renamed the function
Comment on attachment 273415 [details] Renamed the function View in context: https://bugs.webkit.org/attachment.cgi?id=273415&action=review r=me > Source/WebCore/html/FormAssociatedElement.cpp:86 > +// since inDocument flag maybe inaccurate. s/maybe/may be/ ? Thanks for the review! (In reply to comment #3) > Comment on attachment 273415 [details] > Renamed the function > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273415&action=review > > r=me > > > Source/WebCore/html/FormAssociatedElement.cpp:86 > > +// since inDocument flag maybe inaccurate. > > s/maybe/may be/ ? Revised the whole comment as: // Compute the highest ancestor instead of calling Node::rootNode in removedFrom / formRemovedFromTree // since inDocument flag on some form associated elements may not have been updated yet. Committed r197887: <http://trac.webkit.org/changeset/197887> |