Bug 155215

Summary:

Element with maximum tabIndex cannot be returned by nextElementWithGreaterTabIndex()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, darin, rniwa, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=155159
https://bugs.webkit.org/show_bug.cgi?id=155233

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2016-03-08 20:41:38 PST

Element with maximum tabIndex cannot be returned by nextElementWithGreaterTabIndex() due to a bug in <http://trac.webkit.org/changeset/197726>.

Comment 1 Chris Dumez 2016-03-08 20:49:47 PST

Created attachment 273384 [details]
Patch

Comment 2 WebKit Commit Bot 2016-03-08 22:27:43 PST

Comment on attachment 273384 [details]
Patch

Clearing flags on attachment: 273384

Committed r197835: <http://trac.webkit.org/changeset/197835>

Comment 3 WebKit Commit Bot 2016-03-08 22:27:47 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Alexey Proskuryakov 2016-03-08 23:09:22 PST

The new test always times out on iOS. Can it be rewritten to work in a cross-platform way?

Comment 5 Chris Dumez 2016-03-09 09:17:09 PST

(In reply to comment #4)
> The new test always times out on iOS. Can it be rewritten to work in a
> cross-platform way?

In EventSenderProxyIOS.mm:
void EventSenderProxy::keyDown(WKStringRef key, WKEventModifiers modifiers, unsigned keyLocation)
{
    // Write me.
}

iOS does not support EventSender.keydown() :/

Comment 6 Darin Adler 2016-03-09 09:57:35 PST

But you don’t move focus to the next element by pressing a "tab key" on iOS either. I’m not sure that WebKit on iOS has code that understands the tab character. We might have to write something different to test tabIndex on that platform. Not sure there is a platform independent way of walking through the tab loop.