Bug 155213 – Add runtime flags for shadow DOM and custom elements

• Component: DOM
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Add two runtime flags for shadow DOM and custom elements both behind compile time flags, and enable shadow DOM by default.

[Ryosuke Niwa]

Created attachment 273385 [details]
Patch

[Ryosuke Niwa]

Created attachment 273386 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/25053091>

[Build Bot]

Comment on attachment 273386 [details]
Patch

Attachment 273386 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/945311

New failing tests:
fast/custom-elements/Document-defineElement.html
fast/custom-elements/parser/parser-constructs-custom-element-synchronously.html
fast/custom-elements/parser/parser-uses-registry-of-owner-document.html
fast/custom-elements/upgrading/Node-cloneNode.html
fast/custom-elements/parser/parser-fallsback-to-unknown-element.html
fast/custom-elements/parser/parser-uses-constructed-element.html
fast/custom-elements/attribute-changed-callback.html
fast/custom-elements/parser/parser-constructs-custom-elements.html
fast/custom-elements/parser/parser-constructs-custom-element-in-document-write.html
fast/custom-elements/parser/parser-sets-attributes-and-children.html
fast/custom-elements/lifecycle-callback-timing.html
fast/custom-elements/HTMLElement-constructor.html
fast/custom-elements/Document-createElement.html

[Build Bot]

Created attachment 273391 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273386 [details]
Patch

Attachment 273386 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/945318

New failing tests:
fast/custom-elements/parser/parser-uses-registry-of-owner-document.html
fast/custom-elements/parser/parser-constructs-custom-element-synchronously.html
fast/custom-elements/Document-defineElement.html
fast/custom-elements/upgrading/Node-cloneNode.html
fast/custom-elements/parser/parser-fallsback-to-unknown-element.html
fast/custom-elements/parser/parser-uses-constructed-element.html
fast/custom-elements/attribute-changed-callback.html
fast/custom-elements/parser/parser-constructs-custom-elements.html
fast/custom-elements/parser/parser-constructs-custom-element-in-document-write.html
fast/custom-elements/parser/parser-sets-attributes-and-children.html
fast/custom-elements/lifecycle-callback-timing.html
fast/custom-elements/HTMLElement-constructor.html
fast/custom-elements/Document-createElement.html

[Build Bot]

Created attachment 273393 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Ryosuke Niwa]

Created attachment 273396 [details]
Fixed DRT

[Ryosuke Niwa]

Unfortunately, we can't quite test the runtime enabled-ness of these features correctly because attributes and functions on IDL objects are exposed as the global object is created.

We should able to add tests once that bug is fixed.

[Csaba Osztrogonác]

(In reply to comment #0)
> Add two runtime flags for shadow DOM and custom elements both behind compile
> time flags, and enable shadow DOM by default.

Do we want to enable these features on GTK, EFL and Windows ports too.
I checked their cmake build files and it seems they are still disabled.
If yes, please announce it on webkit-dev similar to the recent SVG->OTF thread.

[Ryosuke Niwa]

(In reply to comment #10)
> (In reply to comment #0)
> > Add two runtime flags for shadow DOM and custom elements both behind compile
> > time flags, and enable shadow DOM by default.
> 
> Do we want to enable these features on GTK, EFL and Windows ports too.
> I checked their cmake build files and it seems they are still disabled.
> If yes, please announce it on webkit-dev similar to the recent SVG->OTF
> thread.

Eventually but not now.

[Ryosuke Niwa]

Committed r197921: <http://trac.webkit.org/changeset/197921>