Bug 155209

Summary: CRASH at WebCore::RenderView::updateVisibleViewportRect
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Jer Noble
Reported 2016-03-08 16:59:21 PST
CRASH at WebCore::RenderView::updateVisibleViewportRect
Attachments
Patch (4.83 KB, patch)
2016-03-08 20:31 PST, Jer Noble 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-03-08 16:59:44 PST
<rdar://problem/23997530>
Jer Noble
Comment 2 2016-03-08 20:31:28 PST
Created attachment 273382 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-03-08 21:21:58 PST
Comment on attachment 273382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273382&action=review > Source/WebCore/html/HTMLMediaElement.cpp:796 > + if (renderer() && renderer()->isRegisteredForVisibleInViewportCallback()) > renderer()->unregisterForVisibleInViewportCallback(); Would it be bad to just unconditionally call unregisterForVisibleInViewportCallback()? > LayoutTests/media/video-crash-invisible-autoplay-display-none.html:11 > + run('internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")'); This run() thing is weird. Does it just log and eval?
Jer Noble
Comment 4 2016-03-08 22:08:56 PST
(In reply to comment #3) > Comment on attachment 273382 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273382&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:796 > > + if (renderer() && renderer()->isRegisteredForVisibleInViewportCallback()) > > renderer()->unregisterForVisibleInViewportCallback(); > > Would it be bad to just unconditionally call > unregisterForVisibleInViewportCallback()? Not really, as unregister...() checks whether it's actually registered itself as well. > > LayoutTests/media/video-crash-invisible-autoplay-display-none.html:11 > > + run('internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")'); > > This run() thing is weird. Does it just log and eval? Yep. I like that it shows what's going on in the results.
Jer Noble
Comment 5 2016-03-10 20:25:42 PST
Committed r197989: <http://trac.webkit.org/changeset/197989>
Jer Noble
Comment 6 2016-03-10 20:26:12 PST
*** Bug 155344 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.