Bug 155191

Summary: [GTK] Enable the SVG -> OTF Font Converter
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Myles C. Maxfield
Reported 2016-03-08 13:42:43 PST
[GTK] Enable the SVG -> OTF Font Converter
Attachments
Patch (1.47 KB, patch)
2016-03-08 13:43 PST, Myles C. Maxfield 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-03-08 13:43:03 PST
Created attachment 273325 [details] Patch
Martin Robinson
Comment 2 2016-03-08 14:23:48 PST
Comment on attachment 273325 [details] Patch No objections from me and no one else said anything in the original thread, so I think we should go ahead with this. I'll watch the bots, which already have many failing tests.
Michael Catanzaro
Comment 3 2016-03-08 15:28:17 PST
Comment on attachment 273325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273325&action=review I was expecting this to be some big project, rather than a one-liner. :) Anyway, it's the start of a release cycle, so if anything breaks from this, we have plenty of time to fix it. > Source/cmake/OptionsGTK.cmake:170 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SVG_OTF_CONVERTER PRIVATE ON) This is a list of settings for which the GTK port differs from the WebKit project default value, defined in WebKitFeatures.cmake. Since the default value is ON, we should remove it from this list.
Myles C. Maxfield
Comment 4 2016-03-08 15:59:09 PST
Committed r197814: <http://trac.webkit.org/changeset/197814>
Note You need to log in before you can comment on or make changes to this bug.