Bug 155190

Summary: Web Inspector: Add Heap domain start/stop tracking commands
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 155188    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] Proposed Fix
bburg: review+
[PATCH] For Bots (Part 1 and 2)
none
[PATCH] For Bots (Part 1 and 2)
none
[PATCH] For Landing none

Joseph Pecoraro
Reported 2016-03-08 13:39:51 PST
* SUMMARY Add Heap domain start/stop tracking commands. * NOTES - start/stop should take a heap snapshot
Attachments
[PATCH] Proposed Fix (9.80 KB, patch)
2016-03-08 13:43 PST, Joseph Pecoraro 		bburg: review+
DetailsFormatted DiffDiff
[PATCH] For Bots (Part 1 and 2) (29.75 KB, patch)
2016-03-08 13:44 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] For Bots (Part 1 and 2) (29.79 KB, patch)
2016-03-08 15:40 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] For Landing (9.62 KB, patch)
2016-03-08 17:59 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-08 13:40:39 PST
<rdar://problem/25042708>
Radar WebKit Bug Importer
Comment 2 2016-03-08 13:43:37 PST
<rdar://problem/25042808>
Joseph Pecoraro
Comment 3 2016-03-08 13:43:41 PST
Created attachment 273327 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 4 2016-03-08 13:44:09 PST
Created attachment 273329 [details] [PATCH] For Bots (Part 1 and 2)
Joseph Pecoraro
Comment 5 2016-03-08 15:40:35 PST
Created attachment 273354 [details] [PATCH] For Bots (Part 1 and 2) Better part 1 and 2 patch while this is blocked.
Blaze Burg
Comment 6 2016-03-08 16:43:32 PST
Comment on attachment 273327 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=273327&action=review r=me on the code. However I don't see the point of having start/stop with no update. What is being tracked exactly, memory pressure? allocations? > Source/WebInspectorUI/UserInterface/Protocol/HeapObserver.js:39 > + // FIXME: Heap Allocations Timeline. Please delete or clean up the commented code for landing.
Joseph Pecoraro
Comment 7 2016-03-08 17:04:24 PST
(In reply to comment #6) > Comment on attachment 273327 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273327&action=review > > r=me on the code. However I don't see the point of having start/stop with no > update. What is being tracked exactly, memory pressure? allocations? Eventually there will be an update for tracking all allocations during the recording. That is separate from snapshots and I plan on working on that after the initial UI for snapshots makes it in.
Joseph Pecoraro
Comment 8 2016-03-08 17:59:32 PST
Created attachment 273370 [details] [PATCH] For Landing
Joseph Pecoraro
Comment 9 2016-03-08 18:07:18 PST
<http://trac.webkit.org/changeset/197826>
Note You need to log in before you can comment on or make changes to this bug.