Bug 155162

Summary: Web Inspector: Make WebAutomationSession::closeBrowsingContext work as expected
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2016-03-07 21:58:42 PST
The code for WebAutomationSession::closeBrowsingContext is not working. We need to call a different method to trigger a close via the UIClient of the page.
Attachments
Patch (3.54 KB, patch)
2016-03-07 22:06 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-07 21:58:58 PST
<rdar://problem/25027191>
Timothy Hatcher
Comment 2 2016-03-07 22:06:36 PST
Created attachment 273271 [details] Patch
Blaze Burg
Comment 3 2016-03-07 22:29:15 PST
Comment on attachment 273271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273271&action=review r=me > Source/WebKit2/ChangeLog:4 > + Nit: extra newline not needed
WebKit Commit Bot
Comment 4 2016-03-08 00:55:45 PST
Comment on attachment 273271 [details] Patch Clearing flags on attachment: 273271 Committed r197742: <http://trac.webkit.org/changeset/197742>
WebKit Commit Bot
Comment 5 2016-03-08 00:55:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.