Bug 155162 - Web Inspector: Make WebAutomationSession::closeBrowsingContext work as expected
Summary: Web Inspector: Make WebAutomationSession::closeBrowsingContext work as expected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-07 21:58 PST by Timothy Hatcher
Modified: 2016-03-08 00:55 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2016-03-07 22:06 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-03-07 21:58:42 PST 
The code for WebAutomationSession::closeBrowsingContext is not working. We need to call a different method to trigger a close via the UIClient of the page.
Comment 1 Radar WebKit Bug Importer 2016-03-07 21:58:58 PST 
<rdar://problem/25027191>
Comment 2 Timothy Hatcher 2016-03-07 22:06:36 PST 
Created attachment 273271 [details]
Patch
Comment 3 BJ Burg 2016-03-07 22:29:15 PST 
Comment on attachment 273271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273271&action=review

r=me

> Source/WebKit2/ChangeLog:4
> +

Nit: extra newline not needed
Comment 4 WebKit Commit Bot 2016-03-08 00:55:45 PST 
Comment on attachment 273271 [details]
Patch

Clearing flags on attachment: 273271

Committed r197742: <http://trac.webkit.org/changeset/197742>
Comment 5 WebKit Commit Bot 2016-03-08 00:55:49 PST 
All reviewed patches have been landed.  Closing bug.