Bug 15516
| Summary: | Inspector hangs in Position::isRenderedText() inspecting this file | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | esprehn, mitz |
| Priority: | P2 | Keywords: | NeedsReduction |
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| URL: | http://www.carto.net/neumann/cartography/papermaps/japan.svgz | ||
Eric Seidel (no email)
Inspector hangs in Position::isRenderedText() inspecting this file
I tried inspecting:
http://www.carto.net/neumann/cartography/papermaps/japan.svgz
with the inspector. Trying to toggle the discloser triangle on the root <svg> element hangs Safari in Position::isRenderedText() (or rather the shark sample shows us spending all our time there. I'm not sure if this is an inspector issue or an editing code issue. I think it's an editing code issue. It looks like each call for next() ends up walking the linebox tree if your current position is in a block, but I'm not really sure. I'm not really sure I understand the position code well enough to provide helpful commentary.
I'll attach a shark sample in a sec.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
5.6% 21.5% WebCore WebCore::Position::inRenderedText() const
0.0% 21.5% WebCore WebCore::PositionIterator::isCandidate() const
0.0% 21.5% WebCore WebCore::nextCandidate(WebCore::Position const&)
0.0% 21.5% WebCore WebCore::VisiblePosition::canonicalPosition(WebCore::Position const&)
0.0% 21.5% WebCore WebCore::VisiblePosition::init(WebCore::Position const&, WebCore::EAffinity)
0.0% 21.5% WebCore WebCore::VisiblePosition::VisiblePosition[in-charge](WebCore::Node*, int, WebCore::EAffinity)
0.0% 21.5% WebCore WebCore::RenderText::positionForCoordinates(int, int)
0.0% 21.5% WebCore WebCore::RenderBlock::positionForCoordinates(int, int)
0.0% 21.5% WebCore WebCore::RenderObject::positionForPoint(WebCore::IntPoint const&)
0.0% 21.5% WebCore WebCore::EventHandler::handleMousePressEventSingleClick(WebCore::MouseEventWithHitTestResults const&)
0.0% 21.5% WebCore WebCore::EventHandler::handleMousePressEvent(WebCore::MouseEventWithHitTestResults const&)
0.0% 21.5% WebCore WebCore::EventHandler::handleMousePressEvent(WebCore::PlatformMouseEvent const&)
0.0% 21.5% WebCore WebCore::EventHandler::mouseDown(NSEvent*)
0.0% 21.5% WebKit -[WebHTMLView mouseDown:]
0.0% 21.5% AppKit -[NSWindow sendEvent:]
Elliott Sprehn
This doesn't reproduce anymore.