Bug 155119

Summary: REGRESSION(r197062): [GTK] Transparent backgrounds no longer work after r197062
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2 Keywords: Gtk, Regression
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix coding style mrobinson: review+

Carlos Garcia Campos
Reported 2016-03-07 09:48:54 PST
Try running MiniBrowser --bg-color="rgba(255,0,0,0)" -e for example, you should see the web view transparent, but what we get now is black wen view instead. This is because after r197062 we are now realizing the view too early, even before the toplevel window has been realized, forcing the toplevel window to be realized. If the RGBA visual is set on the window after it has been realzied it doesn't have any effect. We should wait until the toplevel window is realized to realize the web view, giving time to the application to set RGBA visual and background color.
Attachments
Patch (3.72 KB, patch)
2016-03-07 09:52 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Fix coding style (3.72 KB, patch)
2016-03-07 09:56 PST, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-03-07 09:52:41 PST
Created attachment 273191 [details] Patch
WebKit Commit Bot
Comment 2 2016-03-07 09:54:16 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2016-03-07 09:56:04 PST
Created attachment 273192 [details] Fix coding style
Carlos Garcia Campos
Comment 4 2016-03-07 23:18:13 PST
Committed r197733: <http://trac.webkit.org/changeset/197733>
Note You need to log in before you can comment on or make changes to this bug.