Bug 155113

Summary: ElementRuleCollector should not mutate document and style
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, commit-queue, kling, rniwa, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch kling: review+

Antti Koivisto
Reported 2016-03-07 08:13:00 PST
Move applying of style relations out of ElementRuleCollector and StyleResolver. This gets us closer to making StyleResolver const for Element.
Attachments
patch (93.10 KB, patch)
2016-03-07 09:11 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (92.88 KB, patch)
2016-03-07 09:21 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (92.91 KB, patch)
2016-03-07 09:45 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-03-07 09:11:52 PST
Created attachment 273184 [details] patch
WebKit Commit Bot
Comment 2 2016-03-07 09:13:41 PST
Attachment 273184 [details] did not pass style-queue: ERROR: Source/WebCore/style/StyleRelations.cpp:39: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2016-03-07 09:21:34 PST
Created attachment 273186 [details] patch
WebKit Commit Bot
Comment 4 2016-03-07 09:23:11 PST
Attachment 273186 [details] did not pass style-queue: ERROR: Source/WebCore/style/StyleRelations.cpp:39: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 5 2016-03-07 09:45:05 PST
Created attachment 273188 [details] patch
WebKit Commit Bot
Comment 6 2016-03-07 09:46:48 PST
Attachment 273188 [details] did not pass style-queue: ERROR: Source/WebCore/style/StyleRelations.cpp:40: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 7 2016-03-08 01:49:54 PST
Comment on attachment 273188 [details] patch r=me
Ahmad Saleem
Comment 8 2022-07-24 11:53:59 PDT
This landed as part of following: https://github.com/WebKit/WebKit/commit/a83279bfdc4c0c700da87bea326c1c2dcacd2d11 and similarly another commit landed: https://github.com/WebKit/WebKit/commit/af23f8e0eb231b6cd22904c6511993e33651083a I think this can be marked as "RESOLVED FIXED". Thanks!
Note You need to log in before you can comment on or make changes to this bug.