Bug 155102

Summary: Web Inspector: It should be possible to initialize generated ObjC protocol types from an NSDictionary payload
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix
none
For Landing none

Blaze Burg
Reported 2016-03-06 22:06:50 PST
Generate this.
Attachments
Proposed Fix (27.74 KB, patch)
2016-03-06 23:30 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For Landing (28.00 KB, patch)
2016-03-07 09:43 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-06 22:07:06 PST
<rdar://problem/25002015>
Blaze Burg
Comment 2 2016-03-06 23:30:34 PST
Created attachment 273163 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-03-06 23:31:36 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Timothy Hatcher
Comment 4 2016-03-07 09:04:09 PST
Comment on attachment 273163 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=273163&action=review > Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:124 > + lines.append('') You should drop this. It leads to two newlines in a row. > Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:1462 > + > + This should be one newline. See above.
Blaze Burg
Comment 5 2016-03-07 09:43:47 PST
Created attachment 273187 [details] For Landing
Blaze Burg
Comment 6 2016-03-07 09:45:19 PST
(In reply to comment #4) > Comment on attachment 273163 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273163&action=review > > > Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:124 > > + lines.append('') > > You should drop this. It leads to two newlines in a row. > > > Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:1462 > > + > > + > > This should be one newline. See above. Ok. I also guarded this new method so it's only generated when we pass '--frontend' to the generator, and rebaselined.
WebKit Commit Bot
Comment 7 2016-03-07 09:46:05 PST
Attachment 273187 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:164: [ObjCHeaderGenerator._generate_type_interface] Instance of 'ObjCHeaderGenerator' has no 'get_generator_setting' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:94: [ObjCProtocolTypesImplementationGenerator.generate_type_implementation] Instance of 'ObjCProtocolTypesImplementationGenerator' has no 'get_generator_setting' member [pylint/E1101] [5] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2016-03-07 10:41:20 PST
Comment on attachment 273187 [details] For Landing Clearing flags on attachment: 273187 Committed r197689: <http://trac.webkit.org/changeset/197689>
WebKit Commit Bot
Comment 9 2016-03-07 10:41:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.