Bug 155101

Summary: Web Inspector: the protocol generator should have separate prefix options for Objective-C classes and filenames
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, sbarati, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix timothy: review+

Description BJ Burg 2016-03-06 17:07:46 PST
The 'Automation' prefix currently used is redundant with the only domain, 'Automation'.
Comment 1 Radar WebKit Bug Importer 2016-03-06 17:07:59 PST
<rdar://problem/25000053>
Comment 2 BJ Burg 2016-03-06 19:28:49 PST
Created attachment 273159 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-03-06 19:30:26 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2016-03-06 19:30:33 PST
Attachment 273159 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:51:  [ObjCConversionHelpersGenerator.output_filename] Instance of 'ObjCConversionHelpersGenerator' has no 'protocol_name' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:97:  [ObjCGenerator.protocol_name] Instance of 'ObjCGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:103:  [ObjCGenerator.objc_prefix] Instance of 'ObjCGenerator' has no 'model' member  [pylint/E1101] [5]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 BJ Burg 2016-03-06 19:52:10 PST
Committed r197658: <http://trac.webkit.org/changeset/197658>