Summary: | Web Inspector: the protocol generator should have separate prefix options for Objective-C classes and filenames | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
BJ Burg
2016-03-06 17:07:46 PST
Created attachment 273159 [details]
Proposed Fix
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Attachment 273159 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:51: [ObjCConversionHelpersGenerator.output_filename] Instance of 'ObjCConversionHelpersGenerator' has no 'protocol_name' member [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:97: [ObjCGenerator.protocol_name] Instance of 'ObjCGenerator' has no 'model' member [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:103: [ObjCGenerator.objc_prefix] Instance of 'ObjCGenerator' has no 'model' member [pylint/E1101] [5]
Total errors found: 3 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r197658: <http://trac.webkit.org/changeset/197658> |