Bug 155094

Summary:

DFG should know how to speculate StringOrOther

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
work in progress	none
it might be done	none
the patch	saam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews115 for mac-yosemite	none
patch for landing	none

Filip Pizlo

Reported 2016-03-06 12:36:20 PST

Patch forthcoming.

Attachments
work in progress (91.97 KB, patch) 2016-03-06 12:36 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
it might be done (93.77 KB, patch) 2016-03-06 12:43 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (103.13 KB, patch) 2016-03-06 13:30 PST, Filip Pizlo	saam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.08 MB, application/zip) 2016-03-06 14:34 PST, Build Bot	no flags	Details
patch for landing (103.18 KB, patch) 2016-03-06 16:38 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-03-06 12:36:48 PST

Created attachment 273140 [details] work in progress

Filip Pizlo

Comment 2 2016-03-06 12:43:00 PST

Created attachment 273141 [details] it might be done

Filip Pizlo

Comment 3 2016-03-06 13:30:58 PST

Created attachment 273143 [details] the patch

WebKit Commit Bot

Comment 4 2016-03-06 13:32:49 PST

Attachment 273143 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGNode.h:1964: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Saam Barati

Comment 5 2016-03-06 13:59:53 PST

Comment on attachment 273143 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=273143&action=review r=me > Source/JavaScriptCore/ChangeLog:17 > + To do this, I needed to introduce code into the FTL that creates new blocks. We still had that > + awful FTL_NEW_BLOCK idiom since the only way to debug LLVM IR was to ascribe names to basic > + blocks. B3 IR is inherently more debuggable since unlike LLVM, B3 knows how to always respect > + code origin, and it knows how to print the code origin nicely in the dumps. So, rather than > + continue using FTL_NEW_BLOCK(m_out, ("things")), I replaced all of that stuff with > + m_out.newBlock(). It's much nicer that way. Nice!

Build Bot

Comment 6 2016-03-06 14:34:33 PST

Comment on attachment 273143 [details] the patch Attachment 273143 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/933202 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2016-03-06 14:34:35 PST

Created attachment 273146 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Filip Pizlo

Comment 8 2016-03-06 15:54:33 PST

(In reply to comment #7) > Created attachment 273146 [details] > Archive of layout-test-results from ews115 for mac-yosemite > > The attached test failures were seen while running run-webkit-tests on the > mac-debug-ews. > Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5 Looks like I forgot to use ManualOperandSpeculation in some places.

Filip Pizlo

Comment 9 2016-03-06 16:38:28 PST

Created attachment 273154 [details] patch for landing This should resolve the debug test failures.

WebKit Commit Bot

Comment 10 2016-03-06 16:39:55 PST

Attachment 273154 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGNode.h:1964: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 11 2016-03-06 18:07:40 PST

Landed in http://trac.webkit.org/changeset/197649

Note You need to log in before you can comment on or make changes to this bug.