Bug 155085

Summary:

Convert DOMTimer to std::chrono::milliseconds

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebKit Misc.

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, esprehn+autocc, kangil.han

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	none
Fix	none
Fix	kling: review+

Gavin Barraclough

Reported 2016-03-06 00:23:09 PST

DOMTimer currently uses a mix of millisecond (was int, now std::chrono) and second (as double) time values. Constant conversion back and forth is a complete mess. Stop that.

Attachments
Fix (26.56 KB, patch) 2016-03-06 00:36 PST, Gavin Barraclough	no flags	Details Formatted Diff Diff
Fix (27.95 KB, patch) 2016-03-06 22:22 PST, Gavin Barraclough	no flags	Details Formatted Diff Diff
Fix (28.20 KB, patch) 2016-03-06 23:33 PST, Gavin Barraclough	kling: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2016-03-06 00:36:00 PST

Created attachment 273129 [details] Fix

Gavin Barraclough

Comment 2 2016-03-06 22:22:34 PST

Created attachment 273161 [details] Fix

Gavin Barraclough

Comment 3 2016-03-06 23:33:54 PST

Created attachment 273164 [details] Fix

Andreas Kling

Comment 4 2016-03-07 01:45:59 PST

Comment on attachment 273164 [details] Fix r=me, sweet

Gavin Barraclough

Comment 5 2016-03-07 10:41:53 PST

Transmitting file data .................. Committed revision 197690.

Note You need to log in before you can comment on or make changes to this bug.